Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to xAH for Trigger-Level Analyses from GitLab-hosted fork #1675

Closed
wants to merge 1 commit into from
Closed

Updates to xAH for Trigger-Level Analyses from GitLab-hosted fork #1675

wants to merge 1 commit into from
+274 −242

Conversation

mamerl
Copy link
Contributor

@mamerl mamerl commented Feb 15, 2024 •
edited
Loading

Changes include:

  • Modifications to JetCalibrator to allow HLT jets to be re-calibrated with custom changes to JetCalibTools in Athena (Athena changes not yet in main ATLAS repo, but upstreaming changes is planned)
  • Modifications to helper functions & classes to allow booking different variations of histograms, etc.
  • Changes to BasicEventSelection to handle differences in trigger decision handling between physics_Main and physics_TLA data
  • Various other updates, includes some changes already in UCATLAS due to merging UCATLAS main with downstream TLA xAH fork (maybe these need to be removed from the request somehow to prevent changes to all files?)

@mdhank
Copy link
Contributor

mdhank commented Feb 15, 2024

Hi @mamerl ,

It looks like this is starting from an old version of xAH- there are a lot of changes listed, and some of them (such as removing AF3 support) seem to be undoing updates that have been made in the meantime. Would it be possible to rebase this onto a more current version of xAH?

Best,
Michael

@mamerl
Copy link
Contributor Author

mamerl commented Feb 15, 2024

Hi @mdhank,

Thanks for pointing that out. I'm in the process of doing a rebase at the moment so will sort that out and mark this PR as a draft until I have done so.

Thanks,
Max

@mamerl mamerl marked this pull request as draft February 15, 2024 17:45
@mamerl
Copy link
Contributor Author

mamerl commented Feb 16, 2024

Hi @mdhank,

It appears that the rebase didn't work because of some issues with the history for our branch. I'll try to hunt through our commit history and start a new branch from the HEAD of main on my fork of xAODAnaHelpers then will patch the commits for our changes over.

In the meantime, I'll close this PR.

Thanks,
Max

@mamerl mamerl closed this Feb 16, 2024
@mamerl
Copy link
Contributor Author

mamerl commented Feb 16, 2024

For documentation purposes the updated MR is available at #1676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamerl @mdhank